lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87wpoay10o.fsf@tassilo.jf.intel.com>
Date:	Wed, 06 Apr 2016 12:45:27 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	zengzhaoxiu@....com
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	dvlasenk@...hat.com, bp@...e.de, akpm@...ux-foundation.org,
	dvyukov@...gle.com, keescook@...omium.org,
	linux-kernel@...r.kernel.org, Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
Subject: Re: [PATCH v2 10/30] Add x86-specific parity functions

zengzhaoxiu@....com writes:

> From: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
>
> Use alternatives, lifted from arch_hweight

Is there actually anything performance critical in the kernel that uses
parity?

FWIW the arch hweight custom calling convention is a problem for LTO
because it needs different special flags, so I usually have to disable
it. Likely other reasonable usages, such as automatic source code
analysis, and other tool chain based usages have similar problems.

As far as I can tell both for hweight and likely for parity it is
badly overengineering and normal calling conventions would work as well,
and cause much less problems.

So if parity is really worth adding here (which I find doubtful,
but you may have numbers), please add it without these magic
calling hacks.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ