linux-kernel - Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Apr 2016 15:08:46 -0400 (EDT)
From:	Laurence Oberman <loberman@...hat.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	James Bottomley <James.Bottomley@...senpartnership.com>,
	Hiral Patel <hiralpat@...co.com>,
	Suma Ramars <sramars@...co.com>,
	Brian Uchino <buchino@...co.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline
 fnic_queue_abort_io_req, save 1792 bytes

Simple change, looks fine to me.

Reviewed-by: Laurence Oberman <loberman@...hat.com>

Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services

----- Original Message -----
From: "Denys Vlasenko" <dvlasenk@...hat.com>
To: "James Bottomley" <James.Bottomley@...senpartnership.com>
Cc: "Denys Vlasenko" <dvlasenk@...hat.com>, "Hiral Patel" <hiralpat@...co.com>, "Suma Ramars" <sramars@...co.com>, "Brian Uchino" <buchino@...co.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Sent: Friday, April 8, 2016 2:58:43 PM
Subject: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes

This function compiles to 511 bytes of machine code.

Abort commands are not time-critical at all.

Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
CC: James Bottomley <James.Bottomley@...senpartnership.com>
CC: Hiral Patel <hiralpat@...co.com>
CC: Suma Ramars <sramars@...co.com>
CC: Brian Uchino <buchino@...co.com>
CC: linux-scsi@...r.kernel.org
CC: linux-kernel@...r.kernel.org
---
 drivers/scsi/fnic/fnic_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 266b909..0a3edee 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1435,7 +1435,7 @@ wq_copy_cleanup_scsi_cmd:
 	}
 }
 
-static inline int fnic_queue_abort_io_req(struct fnic *fnic, int tag,
+static int fnic_queue_abort_io_req(struct fnic *fnic, int tag,
 					  u32 task_req, u8 *fc_lun,
 					  struct fnic_io_req *io_req)
 {
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html