linux-kernel - Re: [PATCH 5/9] iio: accel: mma7455: use regmap to retrieve struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Apr 2016 14:51:34 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Joachim Eastwood <manabian@...il.com>,
	Alison Schofield <amsfield22@...il.com>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozłowski <k.kozlowski@...sung.com>,
	linux-iio@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 5/9] iio: accel: mma7455: use regmap to retrieve struct
 device

On 06/04/16 08:35, Joachim Eastwood wrote:
> Hi Alison,
> 
> On 6 April 2016 at 07:18, Alison Schofield <amsfield22@...il.com> wrote:
>> Driver includes struct regmap and struct device in its global data.
>> Remove the struct device and use regmap API to retrieve device info.
>>
>> Patch created using Coccinelle plus manual edits.
>>
>> Signed-off-by: Alison Schofield <amsfield22@...il.com>
>> ---
>>  drivers/iio/accel/mma7455_core.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/accel/mma7455_core.c b/drivers/iio/accel/mma7455_core.c
>> index c633cc2..c902f54 100644
>> --- a/drivers/iio/accel/mma7455_core.c
>> +++ b/drivers/iio/accel/mma7455_core.c
>> @@ -55,11 +55,11 @@
>>
>>  struct mma7455_data {
>>         struct regmap *regmap;
>> -       struct device *dev;
>>  };
>>
>>  static int mma7455_drdy(struct mma7455_data *mma7455)
>>  {
>> +       struct device *dev = regmap_get_device(mma7455->regmap);
> 
> ah, nice!
> 
> Acked-by: Joachim Eastwood <manabian@...il.com>
Applied to the togreg  branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

This one is a fairly standard case and can be easily chased through to
see that the device pointer is the same one either way.

I'm going to let the rest sit a little longer to see if we get more
feedback on them

Jonathan
> 
> 
> regards,
> Joachim Eastwood
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>