linux-kernel - Re: [PATCH 06/19] arc: get rid of superfluous __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Apr 2016 14:23:42 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Michal Hocko <mhocko@...nel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Michal Hocko <mhocko@...e.com>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
Subject: Re: [PATCH 06/19] arc: get rid of superfluous __GFP_REPEAT

On Monday 11 April 2016 04:38 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@...e.com>
>
> __GFP_REPEAT has a rather weak semantic but since it has been introduced
> around 2.6.12 it has been ignored for low order allocations.
>
> pte_alloc_one_kernel uses __get_order_pte but this is obviously
> always zero because BITS_FOR_PTE is not larger than 9 yet the page
> size is always larger than 4K.  This means that this flag has never
> been actually useful here because it has always been used only for
> PAGE_ALLOC_COSTLY requests.
>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: linux-arch@...r.kernel.org
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Acked-by: Vineet Gupta <vgupta@...opsys.com>

Thx,
-Vineet