linux-kernel - [PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 11 Apr 2016 11:50:39 -0500
From:	Stuart Yoder <stuart.yoder@....com>
To:	<gregkh@...uxfoundation.org>, <german.rivera@....com>
CC:	<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
	<agraf@...e.de>, <arnd@...db.de>, <leoyang.li@....com>,
	Horia Geantă <horia.geanta@...escale.com>,
	Stuart Yoder <stuart.yoder@....com>
Subject: [PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal_allocate() failures

From: Horia Geantă <horia.geanta@...escale.com>

There are some error paths that allow for a NULL new_mc_io and err = 0
return code. Return -EINVAL instead.

Signed-off-by: Horia Geantă <horia.geanta@...escale.com>
Signed-off-by: Stuart Yoder <stuart.yoder@....com>
---
 drivers/staging/fsl-mc/bus/mc-allocator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c
index 4676ba1..7ee71e7 100644
--- a/drivers/staging/fsl-mc/bus/mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/mc-allocator.c
@@ -306,6 +306,7 @@ int __must_check fsl_mc_portal_allocate(struct fsl_mc_device *mc_dev,
 	if (error < 0)
 		return error;
 
+	error = -EINVAL;
 	dpmcp_dev = resource->data;
 	if (WARN_ON(!dpmcp_dev))
 		goto error_cleanup_resource;
-- 
1.7.9.5