linux-kernel - Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on contents of trust keyring [ver #4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Apr 2016 15:21:59 -0700 (PDT)
From:	Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:	David Howells <dhowells@...hat.com>
cc:	zohar@...ux.vnet.ibm.com, linux-security-module@...r.kernel.org,
	keyrings@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on
 contents of trust keyring [ver #4]


On Thu, 7 Apr 2016, David Howells wrote:

> diff --git a/crypto/asymmetric_keys/pkcs7_trust.c b/crypto/asymmetric_keys/pkcs7_trust.c
> index b9a5487cd82d..0dccb6fe7634 100644
> --- a/crypto/asymmetric_keys/pkcs7_trust.c
> +++ b/crypto/asymmetric_keys/pkcs7_trust.c
> @@ -170,8 +162,7 @@ verified:
>  * May also return -ENOMEM.
>  */
> int pkcs7_validate_trust(struct pkcs7_message *pkcs7,
> -			 struct key *trust_keyring,
> -			 bool *_trusted)

This doesn't build after the keys-trust branch was rebased on v4.6-rc2. A 
reference to _trusted was added in commit e5435891 ("PKCS#7: 
pkcs7_validate_trust(): initialize the _trusted output argument"), right 
after the local declarations.

> +			 struct key *trust_keyring)
> {
> 	struct pkcs7_signed_info *sinfo;
> 	struct x509_certificate *p;

Regards,

--
Mat Martineau
Intel OTC