linux-kernel - Re: [PATCH] coresight: no need to do the forced type conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 09:42:59 -0600
From:	Mathieu Poirier <mathieu.poirier@...aro.org>
To:	lipengcheng <lipengcheng8@...wei.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	lizhong11@...ilicon.com, Feng Chen <puck.chen@...ilicon.com>,
	liuyongfu@...ilicon.com, Dan Zhao <dan.zhao@...ilicon.com>
Subject: Re: [PATCH] coresight: no need to do the forced type conversion

On 13 April 2016 at 03:09, lipengcheng <lipengcheng8@...wei.com> wrote:
> activated and enable are already unsigned type,
> no need to change them to unsigned.
>
> Signed-off-by: Li Pengcheng <lipengcheng8@...wei.com>
> Signed-off-by: Li Zhong <lizhong11@...ilicon.com>
> ---
>  drivers/hwtracing/coresight/coresight.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> index bba9f3d..617574a 100644
> --- a/drivers/hwtracing/coresight/coresight.c
> +++ b/drivers/hwtracing/coresight/coresight.c
> @@ -538,7 +538,7 @@ static ssize_t enable_sink_show(struct device *dev,
>  {
>         struct coresight_device *csdev = to_coresight_device(dev);
>
> -       return scnprintf(buf, PAGE_SIZE, "%u\n", (unsigned)csdev->activated);
> +       return scnprintf(buf, PAGE_SIZE, "%u\n", csdev->activated);
>  }
>
>  static ssize_t enable_sink_store(struct device *dev,
> @@ -568,7 +568,7 @@ static ssize_t enable_source_show(struct device *dev,
>  {
>         struct coresight_device *csdev = to_coresight_device(dev);
>
> -       return scnprintf(buf, PAGE_SIZE, "%u\n", (unsigned)csdev->enable);
> +       return scnprintf(buf, PAGE_SIZE, "%u\n", csdev->enable);
>  }

Applied - thanks.
Mathieu

>
>  static ssize_t enable_source_store(struct device *dev,
> --
> 1.8.3.2
>