linux-kernel - Re: [PATCH] PCI: imx6: Implement reset sequence for i.MX6+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 13:05:10 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Andrey Smirnov <asmirnov@...ceflightindustries.com>,
	Richard Zhu <Richard.Zhu@...escale.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Gary Bisson <gary.bisson@...ndarydevices.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH] PCI: imx6: Implement reset sequence for i.MX6+

Hi Andrey,

On Wed, Apr 13, 2016 at 12:51 PM, Andrey Smirnov
<andrew.smirnov@...il.com> wrote:
> I.MX6+ has a dedicated bit for reseting PCIe core, which should be used
> instead of a regular reset sequence since using the latter will hang the
> SoC.
>
> This commit is based on c34068d48273e24d392d9a49a38be807954420ed from
> http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git
>
> Signed-off-by: Andrey Smirnov <asmirnov@...ceflightindustries.com>
> ---
>  arch/arm/boot/dts/imx6qp.dtsi               |  3 ++

Please put the ARM change into a separate patch.

>  static const struct of_device_id imx6_pcie_of_match[] = {
>         { .compatible = "fsl,imx6q-pcie", },
> +       { .compatible = "fsl,imx6qp-pcie", },

Please base your patch against
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-imx6

,as there is mx6sx support now in this branch.