linux-kernel - Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2016 16:08:06 -0700
From:	"Luis R. Rodriguez" <mcgrof@...nel.org>
To:	David Vrabel <david.vrabel@...rix.com>,
	Ingo Molnar <mingo@...nel.org>
Cc:	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Joey Lee <jlee@...e.com>, lguest@...ts.ozlabs.org,
	Gary Lin <glin@...e.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check
 with platform legacy quirk

On Thu, Apr 7, 2016 at 2:42 AM, David Vrabel <david.vrabel@...rix.com> wrote:
> On 07/04/16 01:06, Luis R. Rodriguez wrote:
>> We have 4 types of x86 platforms that disable RTC:
>>
>>   * Intel MID
>>   * Lguest - uses paravirt
>>   * Xen dom-U - uses paravirt
>>   * x86 on legacy systems annotated with an ACPI legacy flag
>>
>> We can consolidate all of these into a platform specific legacy
>> quirk set early in boot through i386_start_kernel() and through
>> x86_64_start_reservations(). This deals with the RTC quirks which
>> we can rely on through the hardware subarch, the ACPI check can
>> be dealt with separately.
>
> Xen parts:
>
> Reviewed-by: David Vrabel <david.vrabel@...rix.com>

So for instance, I dropped this Reviewed-by given that after this
someone pointed out dom0 as an issue and then I addressed that. Hope
to get a Reviewed-by or Acked-by for v6 then, which will also have the
added __init on xen_dom0_set_legacy_features() as requested by
Juergen.

 Luis