linux-kernel - Re: [PATCH] pm80xx: Remove bogus address masking in pm8001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Apr 2016 14:22:44 +0200
From:	Jinpu Wang <jinpu.wang@...fitbricks.com>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	lindar_liu <lindar_liu@...sh.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>, pmchba@...s.com,
	linux-scsi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap()

On Wed, Apr 13, 2016 at 11:26 PM, David Daney <ddaney.cavm@...il.com> wrote:
> From: David Daney <david.daney@...ium.com>
>
> It is unclear what the original intent of the masking was, but it is
> clearly incorrect to truncate a physical address before calling
> ioremap().  On systems where there are valid physical address bits
> above bit-31 (arm64 for example) the result is an eventual OOPs when
> initializing the driver.
>
> Remove the bogus code to fix it.
>
> Signed-off-by: David Daney <david.daney@...ium.com>
> ---
>  drivers/scsi/pm8001/pm8001_init.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 062ab34..6bd7bf4 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -418,8 +418,6 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha)
>                 if (pci_resource_flags(pdev, bar) & IORESOURCE_MEM) {
>                         pm8001_ha->io_mem[logicalBar].membase =
>                                 pci_resource_start(pdev, bar);
> -                       pm8001_ha->io_mem[logicalBar].membase &=
> -                               (u32)PCI_BASE_ADDRESS_MEM_MASK;
>                         pm8001_ha->io_mem[logicalBar].memsize =
>                                 pci_resource_len(pdev, bar);
>                         pm8001_ha->io_mem[logicalBar].memvirtaddr =
> --
> 1.8.3.1
>

Thanks, looks good to me.
Acked-by: Jack Wang <jinpu.wang@...fitbricks.com>