linux-kernel - Re: [PATCH] fujitsu-laptop: Support radio LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2016 15:30:15 +0930
From:	Jonathan Woithe <jwoithe@...t42.net>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Micha?? K??pie?? <kernel@...pniu.pl>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fujitsu-laptop: Support radio LED

Hi Darren

On Thu, Apr 14, 2016 at 10:44:52PM -0700, Darren Hart wrote:
> On Fri, Apr 15, 2016 at 03:03:33PM +0930, Jonathan Woithe wrote:
> > > I've made a couple cosmetic changes and queued to for-next. Please review
> > > and let me know if you have any concerns.
> > 
> > Sure.  Pardon my ignorance of such things, but what is the most
> > straight-forward way to review the queued commit (preferrably without
> > cloning an entire kernel git repo)?
> 
> You can see the tree in the MAINTAINERS file, but I suppose that doesn't
> make it obvious how to browse it.  You can do that via the git web
> interface on infradead.

Oh, there is a git-web interface on that server.  I should have just
followed my instinct.  Apologies for the noise.

> The direct link to this patch is here:
> 
> http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/commit/34b5199d2b69f9be731233af2425c53cc7ff995b

The commit looks fine to me.  My only question is whether Michal should be
credited explicitly as the author since the patch originated from him (I
essentially just added some comments).  You know the process better than me
though so I'll leave it up to you.

Regards
  jonathan