linux-kernel - Re: [PATCH] checkpatch: Whine about ACCESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Apr 2016 01:27:51 -0700
From:	Joe Perches <joe@...ches.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>,
	Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [PATCH] checkpatch: Whine about ACCESS_ONCE

On Sun, 2016-04-17 at 07:43 +0200, Julia Lawall wrote:
> On Sat, 16 Apr 2016, Joe Perches wrote:
> > On Sat, 2016-04-16 at 12:04 -0700, Joe Perches wrote:
> > > Add a test for use of ACCESS_ONCE that could be written using
> > > READ_ONCE or WRITE_ONCE.
> > > 
> > > --fix it too if desired.
> > 
> > And here's a simple coccinelle script that does a
> > rather better job:
> > 
> > $ cat access_once.cocci
> > @@
> > expression e1;
> > expression e2;
> > @@
> > 
> > -     ACCESS_ONCE(e1) = e2
> > +     WRITE_ONCE(e1, e2)
> > 
> > @@
> > expression e1;
> > @@
> > 
> > -     ACCESS_ONCE(e1)
> > +     READ_ONCE(e1)
> 
> Looks good to me.  Is this something to put in the kernel?

Maybe.  There are more than 500 of these ACCESS_ONCE
uses that could be converted.

The kernel cocci scripts are typically more complicated
with virtual org/report/context/patch blocks.

So perhaps this needs to be fleshed out more.

Works for me as-is though.