linux-kernel - Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Apr 2016 05:24:18 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	John Stultz <john.stultz@...aro.org>,
	Stephen Boyd <stephen.boyd@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	Vinay Simha BN <simhavcs@...il.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key
 entry and use pmic8xxx-pwrkey

On Fri, Apr 15, 2016 at 03:01:06PM -0700, Bjorn Andersson wrote:
> On Fri 15 Apr 11:59 PDT 2016, Stephen Boyd wrote:
> 
> [..]
> 
> > ----8<-----
> > From: Stephen Boyd <sboyd@...eaurora.org>
> > Subject: [PATCH] Input: pmic8xxx-pwrkey: Fix algorithm for converting trigger
> >  delay
> > 
> > The trigger delay algorithm that converts from microseconds to
> > the register value looks incorrect. According to most of the PMIC
> > documentation, the equation is
> > 
> > 	delay (Seconds) = (1 / 1024) * 2 ^ (x + 4)
> > 
> > except for one case where the documentation looks to have a
> > formatting issue and the equation looks like
> > 
> > 	delay (Seconds) = (1 / 1024) * 2 x + 4
> > 
> > Most likely this driver was written with the improper
> > documentation to begin with. According to the downstream sources
> > the valid delays are from 2 seconds to 1/64 second, and the
> > latter equation just doesn't make sense for that. Let's fix the
> > algorithm and the range check to match the documentation and the
> > downstream sources.
> > 
> > Reported-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Applied, thank you.

-- 
Dmitry