linux-kernel - Re: [PATCH] spi: cadence: mark pm functions __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 09:48:07 +0530
From:	Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mark Brown <broonie@...nel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
	Moritz Fischer <moritz.fischer@...us.com>,
	Geliang Tang <geliangtang@....com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: cadence: mark pm functions __maybe_unused

On Sun, Apr 17, 2016 at 2:09 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The newly added runtime PM support for the cadence spi driver
> causes harmless warnings when PM is disabled:
>
> drivers/spi/spi-cadence.c:681:12: warning: 'cnds_runtime_suspend' defined but not used
> drivers/spi/spi-cadence.c:652:12: warning: 'cnds_runtime_resume' defined but not used
>
> This adds __maybe_unused annotations to the respective functions
> to shut up the warnings, while leaving the code in place for
> compile testing and avoiding ugly #ifdefs.

Thanks for the patch.
Feel free to add my ack.
Acked-by: Shubhrajyoti Datta <shubhraj@...inx.com>

>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation")
> ---