linux-kernel - Re: [PATCH] mmc: drop unnecessary bit checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 13:21:22 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH] mmc: drop unnecessary bit checking

On 15 April 2016 at 13:16, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> This if-block is going to call mmc_card_set_blockaddr(), so
> mmc_card_blockaddr() right before it is redundant.
>
> I am fixing the block comment style while I am here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/core/mmc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4dbe3df..c96bc81 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1483,12 +1483,13 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>                 if (err)
>                         goto free_card;
>
> -               /* If doing byte addressing, check if required to do sector
> +               /*
> +                * If doing byte addressing, check if required to do sector
>                  * addressing.  Handle the case of <2GB cards needing sector
>                  * addressing.  See section 8.1 JEDEC Standard JED84-A441;
>                  * ocr register has bit 30 set for sector addressing.
>                  */
> -               if (!(mmc_card_blockaddr(card)) && (rocr & (1<<30)))
> +               if (rocr & BIT(30))
>                         mmc_card_set_blockaddr(card);
>
>                 /* Erase size depends on CSD and Extended CSD */
> --
> 1.9.1
>