linux-kernel - Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 14:01:26 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>
Cc:	gregkh@...uxfoundation.org, stefan@...er.ch,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	Stefan Agner <stefan.agner@...adex.com>
Subject: Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling
 spidev

On Mon, Apr 18, 2016 at 04:48:27PM +0530, Bhuvanchandra DV wrote:

> +++ b/Documentation/ABI/testing/sysfs-bus-spi-spidev
> @@ -0,0 +1,8 @@
> +What:		/sys/bus/spi/drivers/spidev/new_id
> +Date:		March 2016
> +Description:
> +		This allows to load spidev at runtime. new_id file accepts bus
> +		number and chip select in 'B.C' format.
> +		e.g.
> +		To load spidev1.1 at runtime:
> +		$ echo 1.1 > /sys/bus/spi/drivers/spidev/new_id

I would expect a new_id file to allow a new device identifier to be
added to a driver at runtime but this isn't doing that, it's specifying
by bus and chip select instead which is totally different to how we
normally bind SPI devices.  That seems likely to cause confusion down
the line.  I'd expect to be able to supply a DT compatible string or a
Linux SPI ID.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)