linux-kernel - Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 17:33:18 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Jan Kiszka <jan.kiszka@...mens.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd
 ... && pwd)

On Sun, Apr 10, 2016 at 09:04:48PM -0700, Jan Kiszka wrote:
> On 2016-04-08 02:16, Thierry Reding wrote:
> > From: Thierry Reding <treding@...dia.com>
> > 
> > Avoid forking off a shell to resolve the absolute path of the output
> > directory when make's builtin $(abspath ...) function will do an
> > adequate job.
> > 
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > ---
> >  scripts/gdb/linux/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
> > index 6cf1ecf61057..d8b88e22e16a 100644
> > --- a/scripts/gdb/linux/Makefile
> > +++ b/scripts/gdb/linux/Makefile
> > @@ -1,6 +1,6 @@
> >  always := gdb-scripts
> >  
> > -SRCTREE := $(shell cd $(srctree) && /bin/pwd)
> > +SRCTREE := $(abspath $(srctree))
> >  
> >  $(obj)/gdb-scripts:
> >  ifneq ($(KBUILD_SRC),)
> > 
> 
> Thanks, good cleanup. Queued.

You might want to remove this, if it's not too late yet. I posted
another similar thread and people objected to it because it requires
GNU make 3.81, whereas the kernel build process officially still
supports 3.80.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)