linux-kernel - Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2016 23:41:36 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Jeff Layton <jlayton@...chiereds.net>
Cc:	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

On Tue, Apr 19, 2016 at 01:53:17PM -0400, Jeff Layton wrote:

> What's the advantage of using iov_iter_bvec over iov_iter_kvec ?

No need to screw with kmap() in the caller; moreover, when it comes to actual
copying it gets away with kmap_atomic() just around the memcpy(), which is
considerably cheaper.