linux-kernel - Re: [PATCH v2] pinctrl-exynos5440: Use off-stack memory for pinctrl_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2016 17:33:45 +0900
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Andrew Jeffery <andrew@...id.au>,
	Linus Walleij <linus.walleij@...aro.org>
Cc:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Thomas P Abraham <thomas.ab@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl-exynos5440: Use off-stack memory for pinctrl_gpio_range

2016-04-20 15:56 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@...sung.com>:
> On 04/20/2016 03:54 AM, Andrew Jeffery wrote:
>> The range is registered into a linked list which can be referenced
>> throughout the lifetime of the driver. Ensure the range's memory is useful
>> for the same lifetime by adding it to the driver's private data structure.
>>
>> The bug was introduced in the driver's initial commit, which was present in
>> v3.10.
>>
>> Signed-off-by: Andrew Jeffery <andrew@...id.au>
>> Fixes: f0b9a7e521fa ("pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC")
>> Cc: stable@...r.kernel.org
>> ---
>> Since v1:
>>
>> * Add range member kerneldoc addressing Tomasz Figa's comment
>>
>> This is my first contribution to the kernel, so hopefully I've followed all the
>> relevant documentation. If not, please let me know and point me in the right
>> direction!
>>
>> I don't have the means to test the patch, but it compiles. Someone with
>> appropriate hardware should probably give it a spin. From the responses it
>> seems that few might have access, and given the nature of the bug it might be
>> the case that no-one has complained because no-one is affected - is it worth
>> maintaining going forward?
>>
>>  drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 ++++++++-------
>>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> Thank you for your contribution. You already received positive feedback
> on v1 of this patch: Tomasz acked it ("acked-by") and I reviewed it
> ("reviewed-by"). These are called "tags".
>
> When you resubmit patches (unless there is a significant change in the
> patch) please always put accumulated tags after existing tags. Usually
> after signed-off-by, in this case after Cc-stable, so this would look like:
>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>
> Fixes: f0b9a7e521fa ("pinctrl: exynos5440: add pinctrl driver for
> Samsung EXYNOS5440 SoC")
> Cc: stable@...r.kernel.org
> Acked-by: Tomasz Figa <tomasz.figa@...il.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

In any case, I think this is ready for applying with the tags above. Thanks.

Best regards,
Tomasz