linux-kernel - Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2016 09:40:10 +0100
From:	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	linux@....linux.org.uk, mark.rutland@....com,
	andy.gross@...aro.org, david.brown@...aro.org,
	daniel.lezcano@...aro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-soc@...r.kernel.org
Subject: Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst
 for psci_cpuidle_ops

On Tue, Mar 22, 2016 at 10:42:43PM +0800, Jisheng Zhang wrote:
> The psci_cpuidle_ops structures is not over-written, so add "const"
> qualifier and replace __initdata with __initconst.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>  drivers/firmware/psci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> index 6d86881..7d52186 100644
> --- a/drivers/firmware/psci.c
> +++ b/drivers/firmware/psci.c
> @@ -355,7 +355,7 @@ int psci_cpu_suspend_enter(unsigned long index)
>  
>  /* ARM specific CPU idle operations */
>  #ifdef CONFIG_ARM
> -static struct cpuidle_ops psci_cpuidle_ops __initdata = {
> +static const struct cpuidle_ops psci_cpuidle_ops __initconst = {
>  	.suspend = psci_cpu_suspend_enter,
>  	.init = psci_dt_cpu_init_idle,
>  };
> -- 
> 2.8.0.rc3
>