linux-kernel - Re: watchdog: deadlock warning with imx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 15:44:45 +0200
From:	Clemens Gruber <clemens.gruber@...ruber.com>
To:	Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org
Cc:	Wim Van Sebroeck <wim@...ana.be>, linux-kernel@...r.kernel.org
Subject: Re: watchdog: deadlock warning with imx2_wdt driver and systemd

On Wed, Apr 20, 2016 at 09:30:07PM -0700, Guenter Roeck wrote:
> 
> Hi Clemens,
> 
> fix is to drop the call to cancel_delayed_work_sync() from watchdog_release().
> Turns out the call is not necessary.
> 
> I'll send a proper patch in the next couple of days.
> 
> Guenter
> 

Hi Guenter,

thank you for finding the cause of the problem! Removing the
cancel_delayed_work_sync call from watchdog_release in watchdog_dev.c
did fix the lockdep warning on all my boards [without having to revert
commit 11d7aba9ce (watchdog: imx2: Convert to use infrastructure
triggered keepalives) first].

Tested-by: Clemens Gruber <clemens.gruber@...ruber.com>

Cheers,
Clemens