linux-kernel - Re: [PATCH 4/4] mtd: nandsim: add _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Apr 2016 11:13:24 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org,
	Richard Weinberger <richard@....at>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	"Luis R . Rodriguez" <mcgrof@...nel.org>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH 4/4] mtd: nandsim: add __init attribute

On Tue, 19 Apr 2016 14:33:35 +0200
Julia Lawall <Julia.Lawall@...6.fr> wrote:

> Add __init attribute on functions that are only called from other __init
> functions and that are not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig.  Currently, the functions are put in the
> .text.unlikely segment.  Declaring them as __init will cause them to be
> put in the .init.text and to disappear after initialization.
> 
> The result of objdump -x on the functions before the change is as follows:
> 
> 000000000000059a l     F .text.unlikely 0000000000000239 alloc_device
> 000000000000034e l     F .text.unlikely 000000000000002e get_partition_name
> 00000000000007d3 l     F .text.unlikely 00000000000005da init_nandsim
> 
> And after the change it is as follows:
> 
> 0000000000000029 l     F .init.text	0000000000000234 alloc_device
> 0000000000000000 l     F .init.text	0000000000000029 get_partition_name
> 000000000000025d l     F .init.text	00000000000005d5 init_nandsim
> 
> Done with the help of Coccinelle.  The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/mtd/nand/nandsim.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Boris
-- 
Boris Brezillon, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com