linux-kernel - RE: [PATCH 1/6] bus: Add shared MDIO bus framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 09:39:38 +0530
From:	Pramod Kumar <pramod.kumar@...adcom.com>
To:	David Miller <davem@...emloft.net>
Cc:	robh+dt@...nel.org, catalin.marinas@....com, will.deacon@....com,
	yamada.masahiro@...ionext.com, wens@...e.org,
	bcm-kernel-feedback-list@...adcom.com, pawel.moll@....com,
	mark.rutland@....com, arnd@...db.de, suzuki.poulose@....com,
	punit.agrawal@....com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Anup Patel <anup.patel@...adcom.com>
Subject: RE: [PATCH 1/6] bus: Add shared MDIO bus framework

Hi David,

Thanks for providing input over the patch.  Will address the comment as
described below.

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: 24 April 2016 23:48
> To: pramod.kumar@...adcom.com
> Cc: robh+dt@...nel.org; catalin.marinas@....com; will.deacon@....com;
> yamada.masahiro@...ionext.com; wens@...e.org; bcm-kernel-feedback-
> list@...adcom.com; pawel.moll@....com; mark.rutland@....com;
> arnd@...db.de; suzuki.poulose@....com; punit.agrawal@....com;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; netdev@...r.kernel.org; anup.patel@...adcom.com
> Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
>
> From: Pramod Kumar <pramod.kumar@...adcom.com>
> Date: Thu, 21 Apr 2016 14:48:38 +0530
>
> > +struct shared_mdio_master *shared_mdio_alloc_master(struct device
> *parent,
> > +						    struct device_node
*node)
> > +{
> > +	int ret = 0;
> > +	struct shared_mdio_master *master;
>
> Always order local variable declarations in reverse christmas tree
(longest to
> shortest line) order.
>

Sure. Next patch will address this.

> > +static int shared_mdio_driver_probe(struct device *dev) {
> > +	int rc;
> > +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> > +	struct shared_mdio_driver *drv =
to_shared_mdio_driver(dev->driver);
>
> Likewise.

Sure.

> Please audit your entire submission for this issue.

Sure. I'll audit the entire patch set for above issue.

Regards,
Pramod