linux-kernel - Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 11:26:19 -0500
From:	David Lechner <david@...hnology.com>
To:	Sekhar Nori <nsekhar@...com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Kevin Hilman <khilman@...nel.org>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi

On 04/25/2016 08:30 AM, Sekhar Nori wrote:
> Hi David,
>
> On Saturday 16 April 2016 10:30 PM, David Lechner wrote:
>> All other devices are disabled by default and not all boards will use
>> these devices, so these should be disabled too..
>>
>> da850-evm.dtb already had status = "okay" for these devices.
>> da850-enbw-cmc.dts did not, so they were added.
>>
>> Signed-off-by: David Lechner <david@...hnology.com>
>> Tested-by: Kevin Hilman <khilman@...libre.com>
>
> I applied this and other patches in this series. One nit-pick though.
> The commit description should be independently readable and not only as
> continuation of the headline. Even if this means repeating portion of
> the headline. I fixed this for most of the patches in this series. For
> example, for this patch, I have:
>
>      ARM: dts: da850: disable mdio and eth0 in da850.dtsi
>
>      Disable mdio and eth0 in da850.dtsi file. All other
>      devices are disabled by default and not all boards
>      will use these devices, so these should be disabled too.
>
>      da850-evm.dtb already had status = "okay" for these devices.
>      da850-enbw-cmc.dts did not, so they were added.
>
>      Signed-off-by: David Lechner <david@...hnology.com>
>      Tested-by: Kevin Hilman <khilman@...libre.com>
>      [nsekhar@...com: commit description updates]
>      Signed-off-by: Sekhar Nori <nsekhar@...com>
>
> Its a minor change and I wont reply to all the patches with the changes
> I made. But I pushed the updated v4.7/dt branch in my tree. Do take a
> look at the commit description there.
>
> Thanks,
> Sekhar
>
>


I had a look at the commits. I'll be sure to follow that advice in the 
future.