linux-kernel - Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Apr 2016 12:34:23 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg

On Mon, Apr 25, 2016 at 12:28 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> I think it should be a tristate with "yes/no/ratelimit", and let's
> default to ratelimit.

Oh, and in general we should *not* use "negative" settings. It's
really annoying to have to enable things with a double negative.

So even if you want to disable something, you should see it as an
"enable" that is on by default, and you can then disable things by
turning that setting off.

That just makes things way more logical.

(Which is not to say that we haven't made this mistake in the past, but ...)

              Linus