linux-kernel - Re: [PATCH v2] lib: make sg_pool tristate instead of bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 19:54:19 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	<linux-kernel@...r.kernel.org>, Christoph Hellwig <hch@....de>,
	Ming Lin <ming.l@....samsung.com>,
	Sagi Grimberg <sagi@...mberg.me>,
	"Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v2] lib: make sg_pool tristate instead of bool

>>>>> "Paul" == Paul Gortmaker <paul.gortmaker@...driver.com> writes:

Paul> The recently added Kconfig controlling compilation of this code
Paul> is: lib/Kconfig:config SG_POOL lib/Kconfig: def_bool n

Paul> ...meaning that it currently is not being built as a module by
Paul> anyone, and that tripped my audit looking for modular code that is
Paul> essentially orphaned (i.e. module_exit, and .remove fcns in
Paul> non-modular drivers.)

Paul> In the following discussion, Ming Lin indicated that the original
Paul> intention was to have it tristate, so here we convert it
Paul> accordingly.

Paul> Also fix up a couple spelling issues that appear in the
Paul> surrounding patch context.

Somebody please review...

-- 
Martin K. Petersen	Oracle Linux Engineering