linux-kernel - Re: [PATCH 1/2] bfp tools: Remove expression with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 11:11:26 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Florian Fainelli <f.fainelli@...il.com>,
	<linux-kernel@...r.kernel.org>
CC:	<ast@...nel.org>, <jolsa@...nel.org>, <acme@...hat.com>
Subject: Re: [PATCH 1/2] bfp tools: Remove expression with no effect



On 2016/4/25 10:34, Florian Fainelli wrote:
> Assigning "attr" to "attr" does not have any effect, but was caught by
> Coverity, so let's remove this.
>
> Reported-by: coverity (CID 1354720)
> Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>   tools/build/feature/test-bpf.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
> index b389026839b9..8236df9a46ca 100644
> --- a/tools/build/feature/test-bpf.c
> +++ b/tools/build/feature/test-bpf.c
> @@ -27,7 +27,6 @@ int main(void)
>   	attr.log_level = 0;
>   	attr.kern_version = 0;
>   
> -	attr = attr;
>   	/*
>   	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
>   	 * This call should fail if we run the testcase.

Tested-by: Wang Nan <wangnan0@...wei.com>