lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Apr 2016 01:02:21 +0200 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Phil Reid" <preid@...ctromag.com.au>, "Linus Walleij" <linus.walleij@...aro.org>, "Yong Li" <sdliyong@...il.com> Subject: [PATCH 3.16 175/217] gpio: pca953x: Use correct u16 value for register word write 3.16.35-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Yong Li <sdliyong@...il.com> commit 9b8e3ec34318663affced3c14d960e78d760dd9a upstream. The current implementation only uses the first byte in val, the second byte is always 0. Change it to use cpu_to_le16 to write the two bytes into the register Signed-off-by: Yong Li <sdliyong@...il.com> Reviewed-by: Phil Reid <preid@...ctromag.com.au> Signed-off-by: Linus Walleij <linus.walleij@...aro.org> [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/gpio/gpio-pca953x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -18,6 +18,7 @@ #include <linux/i2c.h> #include <linux/platform_data/pca953x.h> #include <linux/slab.h> +#include <asm/unaligned.h> #ifdef CONFIG_OF_GPIO #include <linux/of_platform.h> #endif @@ -154,7 +155,7 @@ static int pca953x_write_regs(struct pca switch (chip->chip_type) { case PCA953X_TYPE: ret = i2c_smbus_write_word_data(chip->client, - reg << 1, (u16) *val); + reg << 1, cpu_to_le16(get_unaligned((u16 *)val))); break; case PCA957X_TYPE: ret = i2c_smbus_write_byte_data(chip->client, reg << 1,
Powered by blists - more mailing lists