linux-kernel - [tip:efi/core] x86/efi: Enable runtime call flag checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2016 03:45:44 -0700
From:	tip-bot for Mark Rutland <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mark.rutland@....com, dhowells@...hat.com, hpa@...or.com,
	ard.biesheuvel@...aro.org, will.deacon@....com, hertzog@...ian.org,
	mingo@...nel.org, ben@...adent.org.uk, dvhart@...radead.org,
	leif.lindholm@...aro.org, pjones@...hat.com,
	hock.leong.kweh@...el.com, matt@...eblueprint.co.uk,
	catalin.marinas@....com, James.Bottomley@...senPartnership.com,
	peterz@...radead.org, bp@...en8.de, hch@....de,
	dh.herrmann@...il.com, tglx@...utronix.de,
	gregkh@...uxfoundation.org, linux@....linux.org.uk, hare@...e.de,
	linux-kernel@...r.kernel.org
Subject: [tip:efi/core] x86/efi: Enable runtime call flag checking

Commit-ID:  9788375dc4cdc9c00645028384fb40402eab774f
Gitweb:     http://git.kernel.org/tip/9788375dc4cdc9c00645028384fb40402eab774f
Author:     Mark Rutland <mark.rutland@....com>
AuthorDate: Mon, 25 Apr 2016 21:07:11 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Thu, 28 Apr 2016 11:34:13 +0200

x86/efi: Enable runtime call flag checking

Define ARCH_EFI_IRQ_FLAGS_MASK for x86, which will enable the generic
runtime wrapper code to detect when firmware erroneously modifies flags
over a runtime services function call.

For x86 (both 32-bit and 64-bit), we only need check the interrupt flag.

Signed-off-by: Mark Rutland <mark.rutland@....com>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Ben Hutchings <ben@...adent.org.uk>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Christoph Hellwig <hch@....de>
Cc: Darren Hart <dvhart@...radead.org>
Cc: David Herrmann <dh.herrmann@...il.com>
Cc: David Howells <dhowells@...hat.com>
Cc: Greg KH <gregkh@...uxfoundation.org>
Cc: Hannes Reinecke <hare@...e.de>
Cc: Harald Hoyer harald@...hat.com
Cc: James Bottomley <James.Bottomley@...senPartnership.com>
Cc: Kweh Hock Leong <hock.leong.kweh@...el.com>
Cc: Leif Lindholm <leif.lindholm@...aro.org>
Cc: Peter Jones <pjones@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Raphael Hertzog <hertzog@...ian.org>
Cc: Russell King <linux@....linux.org.uk>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Will Deacon <will.deacon@....com>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/1461614832-17633-40-git-send-email-matt@codeblueprint.co.uk
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/include/asm/efi.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index fb085ce..78d1e74 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -3,6 +3,7 @@
 
 #include <asm/fpu/api.h>
 #include <asm/pgtable.h>
+#include <asm/processor-flags.h>
 #include <asm/tlb.h>
 
 /*
@@ -28,8 +29,9 @@
 
 #define MAX_CMDLINE_ADDRESS	UINT_MAX
 
-#ifdef CONFIG_X86_32
+#define ARCH_EFI_IRQ_FLAGS_MASK	X86_EFLAGS_IF
 
+#ifdef CONFIG_X86_32
 
 extern unsigned long asmlinkage efi_call_phys(void *, ...);