linux-kernel - [tip:efi/core] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 02:53:37 -0700
From:	tip-bot for Ingo Molnar <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	peterz@...radead.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	matt@...eblueprint.co.uk, mingo@...nel.org, tglx@...utronix.de
Subject: [tip:efi/core] efi: Remove unnecessary (and buggy) .memmap
 initialization from the Xen EFI driver

Commit-ID:  0ec7ae928a9c19c2b7b8054507d5694a2597065e
Gitweb:     http://git.kernel.org/tip/0ec7ae928a9c19c2b7b8054507d5694a2597065e
Author:     Ingo Molnar <mingo@...nel.org>
AuthorDate: Fri, 29 Apr 2016 10:31:28 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 29 Apr 2016 11:06:15 +0200

efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver

So the following commit:

  884f4f66ffd6 ("efi: Remove global 'memmap' EFI memory map")

... triggered the following build warning on x86 64-bit allyesconfig:

drivers/xen/efi.c:290:47: warning: missing braces around initializer [-Wmissing-braces]

It's this initialization in drivers/xen/efi.c:

  static const struct efi efi_xen __initconst = {
  ...
        .memmap                   = NULL, /* Not used under Xen. */
  ...

which was forgotten about, as .memmap now is an embedded struct:

        struct efi_memory_map memmap;

We can remove this initialization - it's an EFI core internal data structure plus
it's not used in the Xen driver anyway.

Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: ard.biesheuvel@...aro.org
Cc: bp@...en8.de
Cc: linux-tip-commits@...r.kernel.org
Cc: tony.luck@...el.com
Link: http://lkml.kernel.org/r/20160429083128.GA4925@gmail.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/xen/efi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index be7e56a..e9d2135 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -316,7 +316,6 @@ static const struct efi efi_xen __initconst = {
 	.get_next_high_mono_count = xen_efi_get_next_high_mono_count,
 	.reset_system             = NULL, /* Functionality provided by Xen. */
 	.set_virtual_address_map  = NULL, /* Not used under Xen. */
-	.memmap                   = NULL, /* Not used under Xen. */
 	.flags			  = 0     /* Initialized later. */
 };