linux-kernel - Re: [GIT PULL] move ARM LCD display driver to auxdisplay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 17:53:17 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	Robin van der Gracht <robin@...tonic.nl>,
	"arm@...nel.org" <arm@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Miguel Ojeda Sandonis <maxextreme@...il.com>
Subject: Re: [GIT PULL] move ARM LCD display driver to auxdisplay

On 28/04/16 12:26, Maxime Ripard wrote:
> On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote:
>> On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard
>> <maxime.ripard@...e-electrons.com> wrote:
>>> On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
>>>> Hi ARM SoC guys,
>>>>
>>>> these two patches move the ARM character LCD driver from
>>>> misc drivers to the auxdisplay subsystem where it belongs and
>>>> updates the defconfig for the RealView accordingly.
>>>>
>>>> Please pull it into some cleanup branch in the ARM SoC
>>>> tree.
>>>>
>>>> I tried to get some ACK from the auxdisplay maintainer but no
>>>> reaction.
>>>
>>> Auxdisplay is not a new framework, but rather a very old one.
>>>
>>> It got introduced in 2.6.21, and only received a couple of drivers
>>> since.
>>
>> Small problem for me, but Robin is submitting a brand new
>> auxdisplay driver:
>> http://marc.info/?l=linux-kernel&m=146001950512999&w=2
>> http://marc.info/?l=linux-kernel&m=146001988013230&w=2
> 
> My understanding is that Tomi doesn't want any new fbdev drivers, so
> I'm not sure this is the right place for those patches.

Hmm, that one looks like an fbdev driver, not an auxdisplay driver. But,
not relevant for this patch, of course.

>>> It seems to be quite redundant with fbdev deferred_io, which itself is
>>> almost deprecated these days.
>>
>> That is a valid argument for moving cfag12864b* out to
>> drivers/video/* I guess, but it has nothing to do with this
>> driver whatsoever.
>>
>> This driver has nothing to do with fbdev. Nothing at all.
>> It so not connected to any framebuffer.
>>
>> This driver gets moved to auxdisplay to match the existing
>> LCD driver in drivers/auxdisplay/ks0108.c which is a similar
>> hardware, driving an LCD that likewise has nothing to do
>> with fbdev.
> 
> My bad, I thought all auxdisplay drivers were fbdev ones, but I was
> wrong, obviously. And now, I don't really know what auxdisplay is
> about anymore :)
> 
> Still, moving it to a "framework" that has been inactive for so long
> (and you even mention it in your PR) doesn't seem like the right move.

I think this move makes sense. It's only moving a file to a directory
that at least mentions "display", not really moving it into a framework
(because there doesn't seem to be any).

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)