linux-kernel - Re: [PATCH 4/5] crypto: Use dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 22:37:50 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org,
	Arnaud Ebalard <arno@...isbad.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] crypto: Use dma_pool_zalloc

On Fri, 29 Apr 2016 22:09:11 +0200
Julia Lawall <Julia.Lawall@...6.fr> wrote:

> Dma_pool_zalloc combines dma_pool_alloc and memset 0.  The semantic patch
> that makes this transformation is as follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression d,e;
> statement S;
> @@
> 
>         d =
> -            dma_pool_alloc
> +            dma_pool_zalloc
>              (...);
>         if (!d) S
> -       memset(d, 0, sizeof(*d));
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> 
> ---
> 
>  drivers/crypto/marvell/tdma.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c
> index 7642798..0ad8f1e 100644
> --- a/drivers/crypto/marvell/tdma.c
> +++ b/drivers/crypto/marvell/tdma.c
> @@ -99,12 +99,11 @@ mv_cesa_dma_add_desc(struct mv_cesa_tdma_chain *chain, gfp_t flags)
>  	struct mv_cesa_tdma_desc *new_tdma = NULL;
>  	dma_addr_t dma_handle;
>  
> -	new_tdma = dma_pool_alloc(cesa_dev->dma->tdma_desc_pool, flags,
> -				  &dma_handle);
> +	new_tdma = dma_pool_zalloc(cesa_dev->dma->tdma_desc_pool, flags,
> +				   &dma_handle);
>  	if (!new_tdma)
>  		return ERR_PTR(-ENOMEM);
>  
> -	memset(new_tdma, 0, sizeof(*new_tdma));
>  	new_tdma->cur_dma = dma_handle;
>  	if (chain->last) {
>  		chain->last->next_dma = cpu_to_le32(dma_handle);



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com