linux-kernel - Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 May 2016 01:18:00 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Michael Thalmeier <michael.thalmeier@...e.at>
Cc:	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	linux-kernel@...r.kernel.org, linux-nfc@...ts.01.org,
	michael@...lmeier.at
Subject: Re: [PATCH 08/11] NFC: pn533: reduce output when stopping poll

Hi Michael,

On Thu, Apr 21, 2016 at 04:43:56PM +0200, Michael Thalmeier wrote:
> @@ -1259,7 +1259,8 @@ static int pn533_rf_complete(struct pn533 *dev, void *arg,
>  	if (IS_ERR(resp)) {
>  		rc = PTR_ERR(resp);
>  
> -		nfc_err(dev->dev, "RF setting error %d\n", rc);
> +		if (rc != -ENOENT)
> +			nfc_err(dev->dev, "RF setting error %d\n", rc);
Why ?


>  
>  		return rc;
>  	}
> @@ -1416,9 +1417,6 @@ static int pn533_poll_complete(struct pn533 *dev, void *arg,
>  	if (IS_ERR(resp)) {
>  		rc = PTR_ERR(resp);
>  
> -		nfc_err(dev->dev, "%s  Poll complete error %d\n",
> -			__func__, rc);
> -
Why are you removing that one ?

Cheers,
Samuel.