linux-kernel - Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 13:16:39 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Matt Fleming <matt@...eblueprint.co.uk>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/efi-bgrt: Switch all pr_err() to pr_notice() for
 invalid BGRT

On Tue, May 03, 2016 at 01:47:04PM -0400, Josh Boyer wrote:
> The promise of pretty boot splashes from firmware via BGRT was at
> best only that; a promise.  The kernel diligently checks to make
> sure the BGRT data firmware gives it is valid, and dutifully warns
> the user when it isn't.  However, it does so via the pr_err log
> level which seems unnecessary.  The user cannot do anything about
> this and there really isn't an error on the part of Linux to
> correct.
> 
> This lowers the log level by using pr_notice instead.  Users will
> no longer have their boot process uglified by the kernel reminding
> us that firmware can and often is broken when the 'quiet' kernel
> parameter is specified.  Ironic, considering BGRT is supposed to
> make boot pretty to begin with.
> 
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>

Whitespace nit below that I missed on my initial review.  I don't think
it's worth holding up the patch queue for.

> --- a/arch/x86/platform/efi/efi-bgrt.c
> +++ b/arch/x86/platform/efi/efi-bgrt.c
> @@ -43,40 +43,40 @@ void __init efi_bgrt_init(void)
>  		return;
>  
>  	if (bgrt_tab->header.length < sizeof(*bgrt_tab)) {
> -		pr_err("Ignoring BGRT: invalid length %u (expected %zu)\n",
> +		pr_notice("Ignoring BGRT: invalid length %u (expected %zu)\n",
>  		       bgrt_tab->header.length, sizeof(*bgrt_tab));

On this and other lines with continuations, the continuation line was
indented to match the 'pr_err('; changing that to 'pr_notice(' makes
that continuation indentation no longer make sense.  Perhaps it should
change to a single tab, rather than attempting to line up with the start
of the first argument?

- Josh Triplett