linux-kernel - Re: [PATCH v7 1/6] Shared library support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 23:25:27 +0200
From:	Emese Revfy <re.emese@...il.com>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
	PaX Team <pageexec@...email.hu>,
	Brad Spengler <spender@...ecurity.net>,
	kernel-hardening@...ts.openwall.com,
	Michal Marek <mmarek@...e.com>,
	Kees Cook <keescook@...omium.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Brown <david.brown@...aro.org>
Subject: Re: [PATCH v7 1/6] Shared library support

On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

Hi,

> > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> > index 55c96cb..e4e88ab 100644
> > --- a/scripts/Makefile.clean
> > +++ b/scripts/Makefile.clean
> > @@ -38,7 +38,8 @@ subdir-ymn    := $(addprefix $(obj)/,$(subdir-ymn))
> >  __clean-files  := $(extra-y) $(extra-m) $(extra-)       \
> >                    $(always) $(targets) $(clean-files)   \
> >                    $(host-progs)                         \
> > -                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-)
> > +                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-) \
> > +                  $(hostlibs-y) $(hostlibs-m) $(hostlibs-)
> 
> $(hostcxxlibs-y)$(hostcxxlibs-m) is missing here.
> 
> 
> BTW, are you planning to support hostlibs without .so extention in the future?
> 
> 
> You are changing the top Makefile to clean with "*.so" pattern rule.
> 
> Do you need to change both the top Makefile and Makefile.clean
> for belt-and-braces cleaning?

It doesn't delete the *.so files without the hunk from the top Makefile. 
The mrproper and distclean targets remove them with this patch:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/f23b7eb247ccc9f1007e53313af343980dd52591
But I think this isn't the best solution much like doing it from the top Makefile.

-- 
Emese