linux-kernel - Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2016 08:59:23 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Baolin Wang <baolin.wang@...aro.org>, balbi@...nel.org,
	gregkh@...uxfoundation.org, sre@...nel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>, robh@...nel.org,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Ruslan Bilovol <ruslan.bilovol@...il.com>,
	peter.chen@...escale.com, Alan Stern <stern@...land.harvard.edu>,
	r.baldyga@...sung.com, yoshihiro.shimoda.uh@...esas.com,
	Lee Jones <lee.jones@...aro.org>,
	ckeepax@...nsource.wolfsonmicro.com,
	patches@...nsource.wolfsonmicro.com, linux-pm@...r.kernel.org,
	linux-usb@...r.kernel.org,
	device-mainlining@...ts.linuxfoundation.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger
 current limit management

Hi Mark

>> > +static const unsigned int wm831x_usb_limits[] = {
>> > +       0,
>> > +       2,
>> > +       100,
>> > +       500,
>> > +       900,
>> > +       1500,
>> > +       1800,
>> > +       550,
>> > +};
>
>> Just for curiosity, How these current limits are getting decided?
>> Can we have some proper defines over here so that it can be grasped easily?
>
> They're in the silicon, it's just a table of values that were put into
> the silicon at design time.  The defines would just be TABLE_ENTRY_1 or
> whatever.

Thanks for the clarification, In that case, comments/documentation
will work instead of making any defines.

Regards
Manish Badarkhe