linux-kernel - Re: [PATCH] rtc: add support for maxim rtc max6916

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 12:53:51 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	venkat.prashanth2498@...il.com
Cc:	a.zummo@...ertech.it, marcus.folkesson@...il.com,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: add support for maxim rtc max6916

Hi,

On 05/05/2016 at 03:09:49 -0700, venkat.prashanth2498@...il.com wrote :
> From: venkat-prashanth <venkat.prashanth2498@...il.com>
> 
> This a patch to add support for
> maxim rtc max6916
> 
> Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@...il.com>
> ---
> ---
>  drivers/rtc/rtc-max6916.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 165 insertions(+)
> 

This is the second version you send since my comments. Please include
the patch version in the subject line.
Also, you need to include a changelog.
Finally, you didn't address many of my comments please do so before
submitting again.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com