linux-kernel - Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2016 16:38:20 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Keerthy <j-keerthy@...com>
Cc:	lgirdwood@...il.com, lee.jones@...aro.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, robh+dt@...nel.org,
	mark.rutland@....com
Subject: Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC
 regulators

On Thu, May 05, 2016 at 10:40:40AM +0530, Keerthy wrote:

> +static const struct of_device_id of_lp873x_match_tbl[] = {
> +	{ .compatible = "ti,lp8733-regulators",},
> +	{ .compatible = "ti,lp8732-regulators",},
> +	{ .compatible = "ti,lp873x-regulators",},
> +	{},
> +};

There should be no need for compatible strings here, we already know
what device this is from the parent.  The way we split drivers up for
Linux is something that's internal to Linux and shouldn't be in the
device tree.  If we do have explicit compatible strings then they should
(as always) be specific to a device, no wildcards.

Otherwise this looks sensible.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)