linux-kernel - Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 May 2016 13:20:19 +0200
From:	"Maarten Brock" <m.brock@...mierlo.com>
To:	"Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
	"Bryan O'Donoghue" <pure.logic@...us-software.ie>,
	"Peter Hurley" <peter@...leysoftware.com>,
	linux-serial@...r.kernel.org, "Vinod Koul" <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	ismo.puustinen@...el.com,
	"Heikki Krogerus" <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake
 interface

----- Original Message -----
From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
To: Bryan O'Donoghue [mailto:pure.logic@...us-software.ie], Peter Hurley [mailto:peter@...leysoftware.com], linux-serial@...r.kernel.org, Vinod Koul [mailto:vinod.koul@...el.com], linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, Greg Kroah-Hartman [mailto:gregkh@...uxfoundation.org], ismo.puustinen@...el.com, Heikki Krogerus [mailto:heikki.krogerus@...ux.intel.com]
Sent: Fri, 06 May 2016 12:42:00 +0200
Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface


> On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote:
> > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> > > 
> > > +       bool                    polarity;
> > So this variable is not very intuitively named.
> 
> There is a help above. This is a property of the Synopsys DesignWare DMA
> engine. Anyone familiar with datasheet easily understands this.
> 
> > 
> > You end up setting somepointer->polarity = true; in a later patch. 
> > 
> > Since you're respining a V4 I'd suggest a name that describes a little
> > bit better than polarity. Setting polarity = true is a little bit
> > liked being asked "you you like ice-cream or apple pie" and then
> > saying "yes please".
> 
> It's about handshake interface polarity, so, what about hs_polarity?

So it means: handshake has polarity (true) or handshake has no polarity
(omnidirectional?) (false), right?

Maarten