linux-kernel - Re: [PATCH 0/3] Support MPS2 UART controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 May 2016 15:43:24 +0100
From:	Vladimir Murzin <vladimir.murzin@....com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	jslaby@...e.com, Arnd Bergmann <arnd@...db.de>,
	sudeep.holla@....com, linux-serial@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 0/3] Support MPS2 UART controller

On 06/05/16 15:31, Paul Gortmaker wrote:
> On Mon, Apr 25, 2016 at 4:47 AM, Vladimir Murzin
> <vladimir.murzin@....com> wrote:
>> Hi,
>>
>> These patches allow to use UART controller found on MPS2 platform.
> 
> Did you intend this driver to support being modular?  It has a bool Kconfig
> (not tristate) which makes the module_exit dead code.
> 
> If it will always be builtin (with console as primary use case) then you can
> see commit 89ebc27427695bfc1e769f1dd99bd243d332ac7a as a possible
> update suggestion.

Thanks for the pointer, Paul! I'll see how to update the driver and send
a patch after next merge window closed.

Cheers
Vladimir

> 
> P.
> --
> 
>>
>> Following [1], please, consider to merge them into tty/serial tree.
>>
>> [1] https://lkml.org/lkml/2016/4/23/190
>>
>> Thanks!
>>
>> Vladimir Murzin (3):
>>   dt-bindings: document the MPS2 UART bindings
>>   serial: mps2-uart: add MPS2 UART driver
>>   serial: mps2-uart: add support for early console
>>
>>  .../devicetree/bindings/serial/arm,mps2-uart.txt   |   19 +
>>  drivers/tty/serial/Kconfig                         |   13 +
>>  drivers/tty/serial/Makefile                        |    1 +
>>  drivers/tty/serial/mps2-uart.c                     |  625 ++++++++++++++++++++
>>  include/uapi/linux/serial_core.h                   |    3 +
>>  5 files changed, 661 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/serial/arm,mps2-uart.txt
>>  create mode 100644 drivers/tty/serial/mps2-uart.c
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>