linux-kernel - Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 May 2016 16:47:13 +0200
From:	Radim Krčmář <rkrcmar@...hat.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Borislav Petkov <bp@...e.de>, Brooks Moses <bmoses@...gle.com>,
	linux-kernel@...r.kernel.org, Ian Kasprzak <iankaz@...gle.com>
Subject: Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?

2016-05-09 16:00+0200, Paolo Bonzini:
> On 05/05/2016 10:24, Borislav Petkov wrote:
>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>>> When I run "make ARCH=x86 headers_install", and then write a simple C
>>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>>> compiler error: the BIT() macro used on line 219 of that file is
>>> undefined:
>> 
>> The below patch should help...
>> 
>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
>> stone?
> 
> Unfortuntely it is cast in stone.  The patch below is good though.

We can "fix" it by introducing a second name for the entry.  Do you
think it's worth?

> Radim, please commit it
> (http://article.gmane.org/gmane.linux.kernel/2215443/raw) or pass the
> tree back to me so that I can. :)

I've committed the patch.  The tree is yours now -- there probably is a
lot I missed ...