linux-kernel - Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 May 2016 13:52:56 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	Dave Gerlach <d-gerlach@...com>, Rob Clark <robdclark@...il.com>,
	Dave Airlie <airlied@...il.com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed

On 10/05/16 00:51, Arnd Bergmann wrote:
> In some configurations, we can build the OMAP dss driver without
> implictly including the pinctrl consumer definitions, causing
> a build error:
> 
> gpu/drm/omapdrm/dss/dss.c: In function 'dss_runtime_suspend':
> gpu/drm/omapdrm/dss/dss.c:1268:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index f95ff319e68e..3303cfad4838 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -30,6 +30,7 @@
>  #include <linux/delay.h>
>  #include <linux/seq_file.h>
>  #include <linux/clk.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/gfp.h>

Thanks, queued for omapdrm fixes.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)