linux-kernel - RE: [PATCH 2/3] perf/x86/mbm: Fix mbm counting for RMID reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 May 2016 16:39:39 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Peter Zijlstra <peterz@...radead.org>,
	Vikas Shivappa <vikas.shivappa@...ux.intel.com>
CC:	"Shivappa, Vikas" <vikas.shivappa@...el.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"Shankar, Ravi V" <ravi.v.shankar@...el.com>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	"davidcc@...gle.com" <davidcc@...gle.com>,
	"Stephane Eranian (eranian@...gle.com)" <eranian@...gle.com>
Subject: RE: [PATCH 2/3] perf/x86/mbm: Fix mbm counting for RMID reuse

>>  (3) Also we may not want to count at every sched_in and sched_out
>>      because the MSR reads involve quite a bit of overhead.
>
> Every single other PMU driver just does this; why are you special?

They just have to read a register.  We have to write the IA32_EM_EVT_SEL MSR
and then read from the IA32_QM_CTR MSR ... if we are tracking both local
and total bandwidth, we have to do repeat and wrmr/rdmsr again to get the
other counter.  That seems like it will noticeably affect the system if we do it
on every sched_in and sched_out.

But the more we make this complicated, the more I think that we should not
go through the pain of stealing/recycling RMIDs and just limit the number of
things that can be simultaneously monitored.  If someone tries to monitor one
more thing when all the RMIDs are in use, we should just error out with
-ERUNOUTOFRMIDSTRYAGAINLATER (maybe -EAGAIN???)

-Tony