linux-kernel - Re: [PATCH] NVMe: Only release requested regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 09:34:56 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] NVMe: Only release requested regions

On Thu, May 12, 2016 at 12:03:52AM -0700, Christoph Hellwig wrote:
> >  static void nvme_dev_unmap(struct nvme_dev *dev)
> >  {
> > +	struct pci_dev *pdev = to_pci_dev(dev->dev);
> > +	int bars;
> > +
> >  	if (dev->bar)
> >  		iounmap(dev->bar);
> > -	pci_release_regions(to_pci_dev(dev->dev));
> > +
> > +	bars = pci_select_bars(pdev, IORESOURCE_MEM);
> > +	pci_release_selected_regions(pdev, bars);
> 
> This looks fine, but I really hate this API.
> 
> Can someone add these two nice helpers to pci.h:

Well I could send a patch, but then this is your code...

> 
> static inline int
> pci_request_mem_regions(struct pci_dev *pdev, const char *name)
> {
> 	return pci_request_selected_regions(pdev,
> 			pci_select_bars(pdev, IORESOURCE_MEM), name);
> }
> 
> static inline void
> pci_release_mem_regions(struct pci_dev *pdev)
> {
> 	return pci_release_selected_regions(pdev,
> 			pci_select_bars(pdev, IORESOURCE_MEM));
> }
> 
> But for now this should do it:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Thanks

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850