linux-kernel - Re: [PATCH net] drivers: net: Don't print unpopulated net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 14:27:50 +0100
From:	Harvey Hunt <harvey.hunt@...tec.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	<davem@...emloft.net>, Robert Jarzmik <robert.jarzmik@...e.fr>,
	Barry Song <Baohua.Song@....com>,
	Marcel Ziswiler <marcel@...wiler.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] drivers: net: Don't print unpopulated net_device name

Hi Stephen,

On 10/05/16 19:31, Stephen Hemminger wrote:
> On Tue, 10 May 2016 17:43:21 +0100
> Harvey Hunt <harvey.hunt@...tec.com> wrote:
>
>> For ethernet devices, net_device.name will be eth%d before
>> register_netdev() is called. Don't print the net_device name until
>> the format string is replaced.
>>
>> Cc: Robert Jarzmik <robert.jarzmik@...e.fr>
>> Cc: Barry Song <Baohua.Song@....com>
>> Cc: Marcel Ziswiler <marcel@...wiler.com>
>> Cc: netdev@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>>
>> Signed-off-by: Harvey Hunt <harvey.hunt@...tec.com>
>> ---
>> I've tested this patch on a board that has a DM9000, but haven't
>> tested the other two network devices.
>>
>>   drivers/net/ethernet/davicom/dm9000.c   | 3 +--
>>   drivers/net/ethernet/micrel/ks8695net.c | 3 +--
>>   drivers/net/ethernet/netx-eth.c         | 3 +--
>>   3 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
>> index 48d9194..89dcaa1 100644
>> --- a/drivers/net/ethernet/davicom/dm9000.c
>> +++ b/drivers/net/ethernet/davicom/dm9000.c
>> @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev)
>>   	}
>>
>>   	if (!is_valid_ether_addr(ndev->dev_addr)) {
>> -		dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please "
>> -			 "set using ifconfig\n", ndev->name);
>> +		dev_warn(db->dev, "Invalid ethernet MAC address. Please set using ifconfig\n");
>
> ifconfig is deprecated, therefore please don't tell users to use it.
>

I'll update it to print "Please set using ip".

Thanks,

Harvey