linux-kernel - Re: [PATCH] tools lib traceevent: Do not reassign parg after collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2016 11:27:52 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tools lib traceevent: Do not reassign parg after
 collapse_tree()

Em Thu, May 12, 2016 at 09:57:13PM +0900, Namhyung Kim escreveu:
> Hi Steve,
> 
> On Thu, May 12, 2016 at 4:09 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > At the end of process_filter(), collapse_tree() was changed to update the
> > parg parameter, but the reassignment after the call wasn't removed.
> > What happens is that the "current_op" gets modified and freed and parg
> > is assigned to the new allocated argument. But after the call to
> > collapse_tree(), parg is assigned again to the just freed "current_op",
> > and this causes the tool to crash.
> >
> > current_op must also be assigned to NULL in case of error, otherwise it
> > will cause it to be free()ed twice.
> >
> > Cc: stable@...r.kernel.org # 3.14+
> > Fixes: 42d6194d133c ("tools lib traceevent: Refactor process_filter()")
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied to perf/urgent.

- Arnaldo