linux-kernel - Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 May 2016 08:20:35 +0530
From:	Harini Katakam <harinikatakamlinux@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Harini Katakam <harini.katakam@...inx.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>, davem@...emloft.net,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Punnaiah Choudary Kalluri <punnaia@...inx.com>,
	"michals@...inx.com" <michals@...inx.com>
Subject: Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

HI Andrew,

On Fri, May 13, 2016 at 11:13 PM, Andrew Lunn <andrew@...n.ch> wrote:
> Hi Harini
>
> Is this backward compatible? Will devices using the old binding still
> work?

It isn't right now.
I will have to assign the bus read/write functions conditionally in order to
do that - I'll see if I can make it clean.

>
>   /* Disable RX and TX (XXX: Should we halt the transmission
>    * more gracefully?)
>     */
> -   macb_writel(bp, NCR, 0);
> +   ctrl = macb_readl(bp, NCR);
> +   ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
> +   macb_writel(bp, NCR, ctrl);
>
>         /* Clear the stats registers (XXX: Update stats first?) */
> -       macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
> +       ctrl |= MACB_BIT(CLRSTAT);
> +       macb_writel(bp, NCR, ctrl);
>
>         /* Clear all status flags */
>         macb_writel(bp, TSR, -1);
>
> It is not clear to me what this part has to do with MDIO.
>

Sorry, I'll move this to a separate patch in my next version.
It is intended to write those registers without disturbing reserved bits.

Regards,
Harini