linux-kernel - Re: r8169: Unconditionally disabling ASPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 May 2016 20:42:01 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Paul Menzel <paulepanter@...rs.sourceforge.net>
Cc:	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	David Miller <davem@...emloft.net>,
	Chunhao Lin <hau@...ltek.com>
Subject: Re: r8169: Unconditionally disabling ASPM

Paul Menzel <paulepanter@...rs.sourceforge.net> :
[...]
> As over five years have passed now, do you think that is still needed?
> I wonder why no module parameter was added back then, where users could
> enable ASPM if it works on their systems? Because there is no such
> situation and it always fails?

It was enabled again (d64ec841517a25f6d468bde9f67e5b4cffdc67c7) then
disabled (4521e1a94279ce610d3f9b7945c17d581f804242). It's closer
to 3.5 years :o)

Module parameters are frowned upon.

Lin, is there some interest in selectively [*] enabling (or disabling)
ASPM support in the r8169 driver or will it be unreliable ?

[*] Based on DMI information for instance.

-- 
Ueimor