linux-kernel - RE: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 May 2016 00:17:10 +0000
From:	"Zhang, Jerry" <Jerry.Zhang@....com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>,
	David Airlie <airlied@...ux.ie>
CC:	"Deucher, Alexander" <Alexander.Deucher@....com>,
	"Koenig, Christian" <Christian.Koenig@....com>,
	"Zhou, Jammy" <Jammy.Zhou@....com>,
	Dave Airlie <airlied@...hat.com>,
	"StDenis, Tom" <Tom.StDenis@....com>,
	"Yang, Young" <Young.Yang@....com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable

Reviewed-by: Junwei Zhang <Jerry.Zhang@....com>

Regards,
Jerry (Junwei Zhang)

SRDC SW Development
AMD Shanghai
_____________________________________

> -----Original Message-----
> From: Muhammad Falak R Wani [mailto:falakreyaz@...il.com]
> Sent: Tuesday, May 17, 2016 5:43 PM
> To: David Airlie
> Cc: Deucher, Alexander; Koenig, Christian; Zhou, Jammy; Dave Airlie; StDenis,
> Tom; Yang, Young; Zhang, Jerry; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable
> 
> Remove unused variable 'ret', and directly return 0.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> index 55cdab8..cba951a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> @@ -99,7 +99,6 @@ static void tonga_ih_disable_interrupts(struct
> amdgpu_device *adev)
>   */
>  static int tonga_ih_irq_init(struct amdgpu_device *adev)  {
> -	int ret = 0;
>  	int rb_bufsz;
>  	u32 interrupt_cntl, ih_rb_cntl, ih_doorbell_rtpr;
>  	u64 wptr_off;
> @@ -165,7 +164,7 @@ static int tonga_ih_irq_init(struct amdgpu_device *adev)
>  	/* enable interrupts */
>  	tonga_ih_enable_interrupts(adev);
> 
> -	return ret;
> +	return 0;
>  }
> 
>  /**
> --
> 1.9.1