linux-kernel - [PATCH] udf: Check for IS_ERR in udf_get_pblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 May 2016 10:35:31 -0700
From:	Laura Abbott <labbott@...hat.com>
To:	Jan Kara <jack@...e.com>
Cc:	Laura Abbott <labbott@...oraproject.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] udf: Check for IS_ERR in udf_get_pblock_meta25

udf_find_metadata_inode_efe returns an error pointer, not just
NULL. Check the return with IS_ERR appropriately.

Signed-off-by: Laura Abbott <labbott@...oraproject.org>
---
Came out of https://bugzilla.redhat.com/show_bug.cgi?id=1301295, I never
heard back from the reporter so I've had this sitting around for a bit and
haven't been able to confirm it fixes the crash. The logic makes sense
for the crash though.
---
 fs/udf/partition.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/udf/partition.c b/fs/udf/partition.c
index 5f861ed2..a8ee7fc 100644
--- a/fs/udf/partition.c
+++ b/fs/udf/partition.c
@@ -329,7 +329,7 @@ uint32_t udf_get_pblock_meta25(struct super_block *sb, uint32_t block,
 		}
 
 		inode = mdata->s_mirror_fe;
-		if (!inode)
+		if (IS_ERR(inode))
 			return 0xFFFFFFFF;
 		retblk = udf_try_read_meta(inode, block, partition, offset);
 	}
-- 
2.5.5